Skip to content

512 is max length for variable length Characteristics, not fixed #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2020

Conversation

dhalbert
Copy link
Collaborator

I got this backwards initially:
variable-length characteristics can have up to 512 bytes of data.
Fixed length can have up to 510 bytes, on nRF.
See https://devzone.nordicsemi.com/f/nordic-q-a/12823/maximum-fixed-length-attribute-length-vs-maximum-variable-length-attribute-length.

@dhalbert dhalbert requested review from tannewt and a team May 12, 2020 17:39
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@tannewt tannewt merged commit 5d58457 into adafruit:master May 12, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 15, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.0.1 from 5.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#49 from russmac/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#6 from taradiddles/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.4.2 from 3.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA219#19 from colindgrant/powerdown-constant-spelling

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 3.2.0 from 3.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#35 from brentru/add-cellular-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 6.1.4 from 6.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#81 from dhalbert/max_length

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_LIS331, Adafruit_CircuitPython_BLE_Adafruit
@dhalbert dhalbert deleted the max_length branch May 26, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants